-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): backport split client conn modules #3063
Conversation
Thanks for getting started on this! I'll try to give CI a kick frequently, looks like it needs a |
I'm trying to get Miri fixed, but looks like there is a legit failure reported, that the unit tests are using the deprecated API (as they should, we shouldn't remove tests), and that triggers the |
Sorry about the previously failing CI tests, I'm not familiar with GH workflows and it took a while for me to set them up working. |
Sorry to delay a little, I wanted to check on something. We've had some useful discussion about deprecations in #3052. It seems worth it to put all deprecation warnings behind a Do you want to add that to this PR? If it's too much to do, I can also do it, just let me know :D |
I can add it in the next few days. However, the Also, I guess making the deprecated warnings default should be done with a minor version bump (ie. 0.15) per semantic versioning. |
This patch backports client/conn/http1 and http2 modules from 1.0 to ease transition. It allows code still using 0.14.x to switch to the per-version Connection types available in 1.0.
client::conn::Builder and client:conn:handshake are deprecated as they are removed in 1.0. tower_client is updated so it does not use the deprecated API.
I'd be interesting with helper out here if there is any work needed |
I also wonder if I can do anything to move this forward. |
Sorry, there were a couple of new breaking changes that I realized needed to be made to 1.0. We've made them now. It'd be helpful to users to make sure the "backport helpers" match what ends up in 1.0, so we needed to make them first. For instance, in this PR, the builders no longer have their methods prefixed with the HTTP version (so, not |
Then I guess this PR should be dropped and the issue postponed until it's clear what needs to be backported. |
Backport
client::conn
split modules to ease transition to the 1.0 API and deprecateclient::conn::Builder
andclient::conn::handshake
.Closes #3053